feat: component-bindgen-go ( re-exporting wit-bindgen-go )#247
Closed
lxfontes wants to merge 2 commits intowasmCloud:mainfrom
Closed
feat: component-bindgen-go ( re-exporting wit-bindgen-go )#247lxfontes wants to merge 2 commits intowasmCloud:mainfrom
lxfontes wants to merge 2 commits intowasmCloud:mainfrom
Conversation
Signed-off-by: Lucas Fontes <lucas@cosmonic.com>
Signed-off-by: Lucas Fontes <lucas@cosmonic.com>
brooksmtownsend
approved these changes
Mar 18, 2025
Member
brooksmtownsend
left a comment
brooksmtownsend
left a comment
There was a problem hiding this comment.
Looks super reasonable to me 👍🏻
2 tasks
Member
Author
|
continuing in another PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps all
cmtypes in a local package.The local
cmis a basic re-export from upstream, locking it to a known supported version.Consumers have 2 options:
component-bindgen-goand have the component-sdk pick a compatiblecmpackage;wit-bindgen-goand managecmpackage versioning viago.mod. generated code andcmpackage point to differentcmpackages.I've updated a single example to show the difference and can update the remaining if this direction sems sound.